Add MAVLink message actions #1436
Conversation
Sometimes anything is something.
rafaellehmkuhl
force-pushed
the
add-mavlink-message-actions
branch
from
a777c9b to
0362b51
Compare
There was a problem hiding this comment.
Still reviewing the code and functionalities, but for now, here are some UI observations:
The form is a little bit crammed and the confirm button color needs more contrast.
Try changing the following:
1- Change the confirm button color to white and the others to white but with 80% opacity.
2- Increase the gap-y to let some breeze flow through the form elements :)
3- I think there is no need to repeat Param2 on the box and Parameter 2 on the bottom. Probably only on the box will be fine.
Also, the title 'Message configuration' should be centered on the dialog.
Thanks for the tips! 
|
Any message is accepted as long as it's a valid MAVLink message. For COMMAND_LONG and COMMAND_INT messages, the message fields are pre-defined in the UI. For all other messages, the user should specify the JSON message config manually.
rafaellehmkuhl
force-pushed
the
add-mavlink-message-actions
branch
from
0362b51 to
47eaa28
Compare
Any message is accepted as long as it's a valid MAVLink message.
For
COMMAND_LONGandCOMMAND_INTmessages, the message fields are pre-defined in the UI. For all other messages, the user should specify the JSON message config manually.I intend to do a proper automatic parser for all messages soon.
Fix #825
Fix #826